[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

Thu Jan 20 12:34:30 PST 2022

jdoerfert added inline comments.

================
Comment at: clang/test/OpenMP/declare_target_codegen.cpp:293
-};
-int SS::SSS = 1;
 #endif
----------------
jhuber6 wrote:
> jdoerfert wrote:
> > What happened here?
> That was a special case I added that was only necessary when we were trying to remove things from being hidden. Now that hidden is not the default it's not necessary anymore.
can we keep the test (coverage) anyway

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117806/new/

https://reviews.llvm.org/D117806