[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 20 11:37:14 PST 2022


craig.topper added a comment.

In D117791#3258785 <https://reviews.llvm.org/D117791#3258785>, @RKSimon wrote:

> In D117791#3258602 <https://reviews.llvm.org/D117791#3258602>, @craig.topper wrote:
>
>> Just to confirm since I can't see the test CHECK lines. builtin_elementwise_abs is not undefined for INT_MIN?
>
> That's why I added a copy of the check (from llvm-project\clang\test\CodeGen\X86\avx2-builtins.c) in the summary - the 'is_int_min_poison' flag in the abs intrinsic call is still false

I shouldn't try to read patches too early in the morning I guess. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117791/new/

https://reviews.llvm.org/D117791



More information about the cfe-commits mailing list