[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

Thu Jan 20 08:21:38 PST 2022

dmgreen added a comment.

Thanks for the update. Same(ish) questions for the Arm side. Otherwise this LGTM

================
Comment at: llvm/include/llvm/Support/ARMTargetParser.def:332
+ARM_CPU_NAME("cortex-x1c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
+             ARM::AEK_RAS)
 ARM_CPU_NAME("neoverse-n1", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
----------------
Should this match the ARM::AEK_FP16 | ARM::AEK_DOTPROD from cortex-x1 too?

================
Comment at: llvm/lib/Target/ARM/ARM.td:1446

+def : ProcNoItin<"cortex-x1c",                          [ARMv82a,
+                                                         FeatureHWDivThumb,
----------------
Should this have ProcX1C added?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117202/new/

https://reviews.llvm.org/D117202