[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

Wed Jan 19 22:55:02 PST 2022

craig.topper added inline comments.

================
Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \
+; RUN: llc -mtriple=riscv32 -mattr=+experimental-zve64d,+f,+d,+zfh \
 ; RUN:     -verify-machineinstrs < %s | FileCheck %s
----------------
eopXD wrote:
> achieveartificialintelligence wrote:
> > Do we need `+f` here?
> Yes. D should imply F now. Let me create a another patch for it as the current patch is for zve.
D already implies F in RISCV.td which is what is used for -mattr.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112408/new/

https://reviews.llvm.org/D112408