[PATCH] D117056: [clangd] Properly compute framework-style include spelling

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 19 15:55:09 PST 2022


dgoldman added inline comments.


================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1052
         HFI.IndexHeaderMapHeader = 1;
+    } else if (CurDir->isFramework()) {
+      size_t SlashPos = Filename.find('/');
----------------
sammccall wrote:
> This looks like a separate change, and should have a test in clang.
Will try to split out + add a test tomorrow


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117056/new/

https://reviews.llvm.org/D117056



More information about the cfe-commits mailing list