[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 19 13:22:10 PST 2022

ABataev added a comment.

In D70549#3256063 <https://reviews.llvm.org/D70549#3256063>, @JonChesterfield wrote:

> @ABataev @jhuber6 and I would like to change this to annotate variables with whatever visibility the user asked for.
> Can you recall if the concern about premption here was for the deviceRTL, in which case it can be comprehensively dealt with by internalizing the deviceRTL symbols, or for user defined things in which case we want whatever the linker flag -Bsymbolic maps onto as an IR construct.

Hi, check the original PR, it has all required details. Maybe add a check that if the device is same as the host, then add hidden visibility (to avoid problems with the standard libs etc.), otherwise keep it as is?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list