[PATCH] D5980: unique_ptrify ownership of ModuleFiles in the ModuleManager

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 19 09:59:10 PST 2022


dblaikie added a comment.

In D5980#3253378 <https://reviews.llvm.org/D5980#3253378>, @dblaikie wrote:

> Looks like @dexonsmith got this (putting the ownership in `Chain` & using some iterator adapters to narrow the cleanup scope/fallout) in rGa897f7cd40b12f693acbb04b81ef928244637aae <https://reviews.llvm.org/rGa897f7cd40b12f693acbb04b81ef928244637aae>. Thanks @dexonsmith!

And just because I was looking at the code anyway, I migrated the `FirstVisitState` linked list to `unique_ptr` (thought about `forward_list` but given the handling of raw nodes, it seemed simpler not to do that) in rGbaa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810 <https://reviews.llvm.org/rGbaa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D5980/new/

https://reviews.llvm.org/D5980



More information about the cfe-commits mailing list