[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables
Jon Chesterfield via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 19 06:59:56 PST 2022
JonChesterfield added a comment.
If I'm following correctly, this broke the amdgpu buildbot and it has been moved into staging as a workaround. I haven't debugged what breaks but 'DefaultVisibility' is relatively likely to behave differently on cuda vs hsa systems so that's my first guess.
Comment at: clang/lib/AST/Decl.cpp:792
+ if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(Var))
+ return LinkageInfo::external();
Would this change static variables to non-static and thus introduce multiple definition errors? Not immediately obvious to me that the variables have to be directly visible to other translation units
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits