[PATCH] D117475: [clangd] NFC, emit source ranges in selection debug messages.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 19 06:49:09 PST 2022
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: clang-tools-extra/clangd/Selection.cpp:551
printNodeKind(OS, N);
OS << " ";
return std::move(OS.str());
----------------
hmm, while here, this extra space seems weird.
Previously it was at EOL and invisible.
After this patch it's used, but I think it'd be clearer to move it to the format string.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117475/new/
https://reviews.llvm.org/D117475
More information about the cfe-commits
mailing list