[PATCH] D117475: [clangd] NFC, emit source ranges in selection debug messages.

[Haojian Wu via Phabricator via cfe-commits]

hokein updated this revision to Diff 401219.
hokein added a comment.

address commment, only printing range on push.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117475/new/

https://reviews.llvm.org/D117475

Files:
  clang-tools-extra/clangd/Selection.cpp


Index: clang-tools-extra/clangd/Selection.cpp
===================================================================
--- clang-tools-extra/clangd/Selection.cpp
+++ clang-tools-extra/clangd/Selection.cpp
@@ -778,8 +778,8 @@
                      [](const Attr *A) { return !A->isImplicit(); }))
       return false;
     if (!SelChecker.mayHit(S)) {
-      dlog("{1}skip: {0}", printNodeToString(N, PrintPolicy), indent());
-      dlog("{1}skipped range = {0}", S.printToString(SM), indent(1));
+      dlog("{2}skip: {0}{1}", printNodeToString(N, PrintPolicy),
+           S.printToString(SM), indent());
       return true;
     }
     return false;
@@ -798,7 +798,8 @@
   // Performs early hit detection for some nodes (on the earlySourceRange).
   void push(DynTypedNode Node) {
     SourceRange Early = earlySourceRange(Node);
-    dlog("{1}push: {0}", printNodeToString(Node, PrintPolicy), indent());
+    dlog("{2}push: {0}{1}", printNodeToString(Node, PrintPolicy),
+         Node.getSourceRange().printToString(SM), indent());
     Nodes.emplace_back();
     Nodes.back().ASTNode = std::move(Node);
     Nodes.back().Parent = Stack.top();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117475.401219.patch
Type: text/x-patch
Size: 1143 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220119/f88fd950/attachment.bin>