[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants
Richard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 18 20:44:25 PST 2022
LegalizeAdulthood updated this revision to Diff 401087.
LegalizeAdulthood added a comment.
- For function `isCapsOnly`:
- Declare as static per LLVM style guide
- Simplify boolean expression
- Use `llvm::all_of` on container
- Inline Function `isLiteralTokenSequence` as it is now simpler with `llvm::all_of`
- Update documentation:
- Remove references to core guidelines that aren't implemented
- Add mention of reduced false positives in the release notes
- Give example in check documentation
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116386/new/
https://reviews.llvm.org/D116386
Files:
clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp
clang-tools-extra/docs/ReleaseNotes.rst
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-macro-usage.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116386.401087.patch
Type: text/x-patch
Size: 8001 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220119/0137f9a4/attachment-0001.bin>
More information about the cfe-commits
mailing list