[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 18 13:23:14 PST 2022


sammccall added a comment.

@kadircet What we forgot to think about here is that this allows more semantic checks to happen at template parsing time, which affects diagnostics.

This is OK (in fact good) as if those checks fail the template cannot be instantiated, and the code is IFNDR.
But I should have had a test: https://github.com/llvm/llvm-project/commit/4777eb2954080864bcf9dfca0e828c637268eb13


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107275/new/

https://reviews.llvm.org/D107275



More information about the cfe-commits mailing list