[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 18 12:51:27 PST 2022


carlosgalvezp added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:85
+
+bool isLiteralTokenSequence(const MacroInfo *Info) {
+  return std::all_of(Info->tokens_begin(), Info->tokens_end(),
----------------
LLVM coding standards say that this function should be "static", keeping anonymous namespaces only to classes 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116386/new/

https://reviews.llvm.org/D116386



More information about the cfe-commits mailing list