[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 18 12:01:16 PST 2022
njames93 added a comment.
In D117529#3251949 <https://reviews.llvm.org/D117529#3251949>, @carlosgalvezp wrote:
> Haven't looked much in detail so apologies if my comment is stupid - can't CachedGlobList be used for this purpose? Should be a one-liner change I think.
Not a stupid question, but `CachedGlobList` is doing something very different. That's just caching the result of strings when they are passed to a glob to simplify re-evaluation of the same string.
However this implementation is about avoiding the need to check any check-names when building the list of checks. It's also thread safe unlike `CachedGlobList`.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits