[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added inline comments.


================
Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:76
       // Do not handle EOF newlines.
       if (TargetToken->is(tok::eof) && NewlineToInsert > 0)
         return;
----------------
Is that needed?


================
Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:80
         return;
       Whitespaces.replaceWhitespace(*TargetToken, NewlineToInsert,
+                                    TargetToken->OriginalColumn,
----------------
What if NewlineToInsert is 0? Does that explain @MyDeveloperDay s observation?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117520/new/

https://reviews.llvm.org/D117520