[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

Tue Jan 18 10:05:00 PST 2022

aaron.ballman added a comment.

In D117129#3251705 <https://reviews.llvm.org/D117129#3251705>, @njames93 wrote:

> In D117129#3251577 <https://reviews.llvm.org/D117129#3251577>, @aaron.ballman wrote:
>
>> In D117129#3246403 <https://reviews.llvm.org/D117129#3246403>, @njames93 wrote:
>>
>>> There is a hurdle to overcome with this, Currently each check can have its own include style - which doesn't really make sense.
>>
>> Hmm, I think it could make sense for sizeable projects that have components written by separate teams. Granted, I think it's a bit of a strange situation, but I wouldn't go so far as to say it doesn't make sense.
>
> I'm not saying that different teams having different include styles doesn't make sense. I'm saying one translation unit that runs multiple checks with IncludeInserters where they have different styles doesn't make sense.
> That could result in each check trying to create includes in the same file, but assuming a different include style.

Oh, I see what you mean now: include sort orders that battle one another. Yeah, that is a situation that seems worth warning the user about. Thanks for clarifying!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117129/new/

https://reviews.llvm.org/D117129