[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

[Marek Kurdej via Phabricator via cfe-commits]

curdeius added a comment.

Could you explain more in details the before/after of the fixed bugs, please?
The best would be to develop the patch description.



================
Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:37
+  auto LikelyDefinition = [this](const AnnotatedLine *Line,
+                                 const bool ExcludeEnum = false) {
     if ((Line->MightBeFunctionDecl && Line->mightBeFunctionDefinition()) ||
----------------
Nit and personal preference.


================
Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:146
+      // Handling the case that opening bracket has its own line, with checking
+      // whether the last line already had an opening bracket to guard against
+      // misrecognition.
----------------
I find "bracket" ambiguous.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117520/new/

https://reviews.llvm.org/D117520