[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

gehry via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 17 23:32:28 PST 2022


Sockke accepted this revision.
Sockke added a comment.
This revision is now accepted and ready to land.

I think it looks great and safe enough.  It would be better to turn `!(*ptr).empty()` into `!ptr->empty()`, but I have no particular opinions at this point.  Let's see if @aaron.ballman has any comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115124/new/

https://reviews.llvm.org/D115124



More information about the cfe-commits mailing list