[PATCH] D116521: [CMake] Factor out config prefix finding logic

John Ericson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 17 22:38:36 PST 2022

Ericson2314 marked an inline comment as done.
Ericson2314 added inline comments.

Comment at: llvm/CMakeLists.txt:209
Ericson2314 wrote:
> sebastian-ne wrote:
> > Hi, adding this module path overwrites the `llvm_check_linker_flag` from `llvm/cmake/modules/LLVMCheckLinkerFlag.cmake` with the one defined in `cmake/Modules/CheckLinkerFlag.cmake`, which does not check the linker but the compiler.
> > This breaks our gcc+ld build because ld does not support `--color-diagnostics`.
> > 
> > Our downstream issue is here: https://github.com/GPUOpen-Drivers/llpc/issues/1645
> Thanks for letting me know. Let's just rename the `/cmake` one then; nothing there is installed, on purpose, so we can change it freely without worrying breaking an interface used downstream.
> I will make a patch for that in the next 2 days if no one beats me to it.
D117537 fixes this.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list