[PATCH] D117409: [clang-tidy] Move IncludeInserter into ClangTidyContext

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 17 21:58:59 PST 2022

LegalizeAdulthood added inline comments.

Comment at: clang-tools-extra/clang-tidy/IncludeInserter.h:20
 namespace tidy {
-namespace utils {
njames93 wrote:
> LegalizeAdulthood wrote:
> > njames93 wrote:
> > > LegalizeAdulthood wrote:
> > > > What's the guidance on what belongs in `clang::tidy`
> > > > and what belongs in `clang::tidy::utils`?
> > > Well as the file moved out of utils, its no longer in the utils namespace.
> > Yes, if you move the file out of utils then it shouldn't be in the
> > utils namespace.  But why move the file in the first place?
> > 
> > IOW, what is the guideline for what files belong under `utils`
> > and what files belong under `clang-tidy`?
> Utils is for utilities that checks can make use of, but aren't required for the base clang-tidy infra to work.
> By having the Inserter as a dependancy for ClangTidyDiagnosticConsumer it is now required for clang-tidy infrastructure, hence it was moved out of utils.
OK yeah, that's a good explanation, thanks!

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list