[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

[Richard via Phabricator via cfe-commits]

LegalizeAdulthood added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:192-194
+  if (LastFile != CurrentFile) {
+    LastFile = CurrentFile;
+    newEnum();
----------------
LegalizeAdulthood wrote:
> njames93 wrote:
> > This seems a strange way to decect changes in file when you can just override the FileChanged callback.
> I'll try that.  Does it fire once at the beginning?
Tests continue to pass after switching to `FileChanged`, so looks good.
I'll double check in the debugger.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117522/new/

https://reviews.llvm.org/D117522