[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 17 16:05:56 PST 2022


ksyx created this revision.
ksyx added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks.
ksyx requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

- Fixes https://github.com/llvm/llvm-project/issues/53227 that wrongly indents multiline comments
- Fixes wrong detection of single-line opening bracket when used along with those only opening scopes:

  	void foo()
  	{
  	  {
  		int x;
  	  }
  	}

- Fixes wrong recognition of first line of definition when the line starts with block comment:

          /*
             Some descriptions about function
          */
  	/*inline*/ void bar() {
  	}

- Fixes wrong recognition of enum when used as a type name rather than starting definition block:

  	void foobar(const enum EnumType e) {
  	}


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117520

Files:
  clang/lib/Format/DefinitionBlockSeparator.cpp
  clang/unittests/Format/DefinitionBlockSeparatorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117520.400662.patch
Type: text/x-patch
Size: 11947 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220118/57687387/attachment.bin>


More information about the cfe-commits mailing list