[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment
ksyx via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 17 15:17:59 PST 2022
ksyx added a comment.
In D92257#3004563 <https://reviews.llvm.org/D92257#3004563>, @HazardyKnusperkeks wrote:
> In D92257#3003281 <https://reviews.llvm.org/D92257#3003281>, @byronhe wrote:
>> Hi guys，i found `SpacesInLineCommentPrefix` does not support other encoding such as utf8 ，
>> I am curious why there is a `isAlphanumeric` limit in `BreakableLineCommentSection::BreakableLineCommentSection()` ?
>> I want to make some contribution to make it support utf8, what should i do ?
> The `isAlphanumeric` is there to not break doxygen like comments for example.
> I'm very interested in how you want to tackle that problem. :)
Sorry for digging out this month long thing but I encountered this in one project full of non-alphanumeric comment. If I understood the problem correctly, is it more like avoiding symbols like @ / * rather than avoiding non-ASCII characters like CJK's? In this case, would just not adding space when it is started with symbols make this option usable for wider amount of comment content? :)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits