[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

Ben Shi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 16 07:14:30 PST 2022


benshi001 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:417
+  // '-x assembler-with-cpp' if it has not a '.S' suffix.
+  for (unsigned I = 0; I < DriverArgs.size(); I++) {
+    StringRef Arg(DriverArgs.getArgString(I));
----------------
In this for loop, the key point is which one is found first.

It is OK that `-x assembler-with-cpp` comes first, otherwise an error should be reported.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117423/new/

https://reviews.llvm.org/D117423



More information about the cfe-commits mailing list