[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

[Richard via Phabricator via cfe-commits]

LegalizeAdulthood added a comment.

In D117129#3246403 <https://reviews.llvm.org/D117129#3246403>, @njames93 wrote:

> There is a hurdle to overcome with this, Currently each check can have its own include style - which doesn't really make sense. Hopefully people actually just use the global version of the option instead.
> However if we were to coalesce all checks to use the same `IncludeInserter`, we would have to force clang-tidy to just read the global version.
> Going this route it'd be best if we warned on configs that specify their own IncludeStyle. I've created a draft implementation above, definitely needs work though.

I pushed the functionality down into ClangTidyCheck
instead of introducing an intermediate class.  Does this
address your concern?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117129/new/

https://reviews.llvm.org/D117129