[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

[Alex Lorenz via Phabricator via cfe-commits]

arphaman created this revision.
arphaman added reviewers: ravikandhadai, egorzhdan, aaron.ballman, rsmith.
Herald added subscribers: ributzka, kristof.beyls, mgorny.
arphaman requested review of this revision.

Recently we observed high memory pressure caused by clang during some parallel builds. We discovered that we have several projects that have a large number of `#define` directives in their TUs (on the order of millions), which caused huge memory consumption in clang due to a lot of allocations for `MacroInfo`. We would like to reduce the memory overhead of clang for a single `#define` to reduce the memory overhead for these files, to allow us to reduce the memory pressure on the system during highly parallel builds. This change achieves that by removing the `SmallVector` in `MacroInfo` and instead storing the tokens in an array allocated using the bump pointer allocator, after all tokens are lexed.

The added unit test with 1000000 `#define` directives illustrates the problem. Prior to this change,  on arm64 macOS, clang's PP bump pointer allocator allocated 272007616 bytes, and used roughly 272 bytes per `#define`. After this change, clang's PP bump pointer allocator allocates 120002016 bytes, and uses only roughly 120 bytes per `#define`.

For an example test file that we have internally with 7.8 million `#define` directives, this change produces the following improvement on arm64 macOS: Persistent allocation footprint for this test case file as it's being compiled to LLVM IR went down 22% from 5.28 GB to 4.07 GB and the total allocations went down 14% from 8.26 GB to 7.05 GB. Furthermore, this change reduced the total number of allocations made by the system for this clang invocation from 1454853 to 133663, an order of magnitude improvement.


https://reviews.llvm.org/D117348

Files:
  clang/include/clang/Lex/MacroInfo.h
  clang/lib/Lex/MacroInfo.cpp
  clang/lib/Lex/PPDirectives.cpp
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/unittests/Lex/CMakeLists.txt
  clang/unittests/Lex/PPMemoryAllocationsTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117348.400076.patch
Type: text/x-patch
Size: 16201 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220114/9b9ec1f3/attachment-0001.bin>