[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

I think the test behavior is pretty mysterious and there's likely some other bug happening, but this is incremental progress and definitely fixes an issue, so LGTM!



================
Comment at: clang/test/Modules/cxx20-export-import.cpp:1-2
+
+// RUN: %clang_cc1 -std=c++20 -fmodules -fmodules-cache-path=%t -fimplicit-module-maps -I%S/Inputs -stdlib=libc++ -verify %s
+export import dummy; // expected-error {{export declaration can only be used within a module interface unit after the module declaration}}
----------------
tbaeder wrote:
> aaron.ballman wrote:
> > Also, does this test require `-fmodules-cache-path=%t` or `-fimplicit-module-maps`?
> They are all needed (including the `-I`). I could only remove the `-stdlib=libc++`, removing any of the others makes the test fail :(
Oh wow, that's... pretty surprising behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116595/new/

https://reviews.llvm.org/D116595