[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

[Arthur O'Dwyer via Phabricator via cfe-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

@Sockke: Throughout, `trivially-copyable` should be `trivially copyable` (two words).
Other than that, sure, I have no particular opinions at this point.



================
Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:179
+      QualType NoRefType = (*InvocationParmType)->getPointeeType();
+      PrintingPolicy PolicyWithSupressedTag(getLangOpts());
+      PolicyWithSupressedTag.SuppressTagKeyword = true;
----------------
Throughout, `Supress` should be `Suppress`.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:118
+
+  Removed a wrong FixIt for trivially-copyable objects wrapped by ``std::move()`` and passed to an rvalue reference parameter. Removal of ``std::move()`` would break the code.
+
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107450/new/

https://reviews.llvm.org/D107450