[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

[Aleksandr Platonov via Phabricator via cfe-commits]

ArcsinX added a comment.

In D116966#3243374 <https://reviews.llvm.org/D116966#3243374>, @aaron.ballman wrote:

> To be clear, I'm trying to figure out whether plugins are *actually* supported on Windows or whether they just so happen to work if the stars line up right for you. If they're supported, then awesome, let's go forward with this. If they're not supported, it's less clear whether we want to make it easier for the stars to line up or not.

That how it work for me (extra cmake flags: -DLLVM_ENABLE_PLUGINS=On -DCLANG_PLUGINS_SUPPORT=On -DLLVM_EXPORT_SYMBOLS_FOR_PLUGINS=On)

  d:\work\llvm-all\build>bin\clang.exe -Xclang -plugin -Xclang print-fns d:\work\1.cpp -c
  error: unable to find plugin 'print-fns'
  
  d:\work\llvm-project\build>bin\clang.exe -fplugin=bin\PrintFunctionNames.dll -Xclang -plugin -Xclang print-fns d:\work\1.cpp -c
  top-level-decl: "main"
  top-level-decl: "a"
  
  d:\work\llvm-project\build>cat CMakeCache.txt | grep BUILD_SHARED_LIB
  BUILD_SHARED_LIBS:BOOL=OFF


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116966/new/

https://reviews.llvm.org/D116966