[PATCH] D116659: [llvm][clang][vfs] NFC: Simplify directory iteration

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added a comment.

> I don't know, I'm a bit skeptical we want to make it so easy to ignore errors so easily. I'd rather require clients to explicitly ignore the error.

That's my gut feeling too. I suspect a bunch of this code should be explicitly ignoring `ENOENT`, but not ignoring e.g. `EACCESS`, `EMFILE `, etc.  It seems like a bug that we're ignoring all errors right now.

If we really want to ignore all the iteration errors, we should do that consistently in llvm::sys::fs not just the wrapper in the VFS layer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116659/new/

https://reviews.llvm.org/D116659