[PATCH] D117107: [clangd] Elide even more checks in SelectionTree.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 13 11:26:12 PST 2022
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, this looks great!
================
Comment at: clang-tools-extra/clangd/Selection.cpp:364
+ return *Offset < First;
+ log("Start {0}", Tok.dumpForTests(SM));
+ StartInvalid = true;
----------------
nit: remove this debug code.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:390
+ return *Offset <= Last;
+ log("End {0}", Tok.dumpForTests(SM));
+ EndInvalid = true;
----------------
and here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117107/new/
https://reviews.llvm.org/D117107
More information about the cfe-commits
mailing list