[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

Thu Jan 13 10:50:02 PST 2022

erichkeane added inline comments.

================
Comment at: clang/test/Preprocessor/init.c:1523
 // WEBASSEMBLY-NEXT:#define __BIGGEST_ALIGNMENT__ 16
+// WEBASSEMBLY-NEXT:#define __BITINT_MAXWIDTH__ 8388608
 // WEBASSEMBLY-NEXT:#define __BOOL_WIDTH__ 8
----------------
aaron.ballman wrote:
> erichkeane wrote:
> > Actually.... why are we testing WEBASSEMBLY/AArch64 only?  I get that these two both do a 'next', but I would presume we'd want a similar test that ends up being for ALL platforms.  Its unfortunate the way that this test is setup, but could we perhaps have a 'triple-less' (or a test that just has a massive number of triples?) test of some sort that just validates this value?
> I agree that'd be nice, but it seems pretty orthogonal to this patch too. The "init" tests definitely need some love because they're incredibly onerous. But I'd prefer that be done another time.
> 
> As for why only here -- the value is identical for all targets currently, so adding tests for other targets would be a great idea, but not really test much of value. However, I can add the lines to the other targets easily enough if you think there's value.
Sure, yeah, I see the lack of value.  I guess if anyone ever tries to make it target-specific we can make them do the additional testing instead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117238/new/

https://reviews.llvm.org/D117238