[PATCH] D117036: [clangd] Remove --inlay-hints flag

Thu Jan 13 00:59:48 PST 2022

sammccall added inline comments.

================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:296
 RetiredFlag<std::string> ClangTidyChecks("clang-tidy-checks");
+RetiredFlag<std::string> InlayHints("inlay-hints");

----------------
kadircet wrote:
> oops, missed this one in the previous revision.
> 
> any reason for not directly dropping it? this was an "experimental flag" which we didn't advertise publicly (until one or two weeks ago, and even then we don't mention the flag, https://clangd.llvm.org/extensions#inlay-hints)
It leaked!

https://chromium.googlesource.com/chromiumos/docs/+/main/chroot-clangd-guide.md
https://stackoverflow.com/a/69656325/1556111

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117036/new/

https://reviews.llvm.org/D117036