[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 12 16:20:21 PST 2022


njames93 added a comment.

In D117129#3238441 <https://reviews.llvm.org/D117129#3238441>, @LegalizeAdulthood wrote:

> Another option would be to migrate this to `ClangTidyCheck` itself
> and add a flag/option passed to the ClangTidyCheck c'tor to opt-in
> to the feature?

I feel that this direction is much better, Its something I wanted to introduce a while back, but my work was getting in the way.
My proposed idea was putting the `IncludeInserter` instance inside the `ClangTidyContext`, but then only registering it if any checks actually want to use it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117129/new/

https://reviews.llvm.org/D117129



More information about the cfe-commits mailing list