[PATCH] D117078: [NFC] Minimize noundef analysis when disabled

Kevin Athey via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 12 13:32:15 PST 2022


kda updated this revision to Diff 399432.
kda marked an inline comment as done.
kda added a comment.

reduce nesting


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117078/new/

https://reviews.llvm.org/D117078

Files:
  clang/lib/CodeGen/CGCall.cpp


Index: clang/lib/CodeGen/CGCall.cpp
===================================================================
--- clang/lib/CodeGen/CGCall.cpp
+++ clang/lib/CodeGen/CGCall.cpp
@@ -2377,9 +2377,9 @@
     }
 
     // Decide whether the argument we're handling could be partially undef
-    if (CodeGenOpts.EnableNoundefAttrs) {
-      if (DetermineNoUndef(ParamType, getTypes(), DL, AI))
-        Attrs.addAttribute(llvm::Attribute::NoUndef);
+    if (CodeGenOpts.EnableNoundefAttrs &&
+        DetermineNoUndef(ParamType, getTypes(), DL, AI)) {
+      Attrs.addAttribute(llvm::Attribute::NoUndef);
     }
 
     // 'restrict' -> 'noalias' is done in EmitFunctionProlog when we


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117078.399432.patch
Type: text/x-patch
Size: 670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220112/af042d52/attachment-0001.bin>


More information about the cfe-commits mailing list