[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

Wed Jan 12 13:16:42 PST 2022

ymandel added a comment.

Overall, this change looks good and makes sense. But, it doesn't scale past 1 feature, which makes me a bit hesitant. I don't have another example offhand, but include-inserter is an arbitrary feature and I don't love conflating feature addition with the class hierarchy. Might there be some other way to get the benefits of saving implementers the cut and paste (and bug-prone code that comes with it) without changing the class hierarchy?

================
Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.h:13
+#include "IncluderClangTidyCheck.h"
 #include "IncludeSorter.h"
 #include "clang/ASTMatchers/ASTMatchFinder.h"
----------------
can you delete this?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117129/new/

https://reviews.llvm.org/D117129