[PATCH] D117078: Minor adjustment in order of noundef analysis to be a bit more optimal (when disabled).

Vitaly Buka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 12 13:07:43 PST 2022


vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

my editor recommends me to keep git titles <50 chars
Maybe something shorter with exactly the same meaning
"[NFC] Optimize noundef analysis condition"



================
Comment at: clang/lib/CodeGen/CGCall.cpp:2380-2381
     // Decide whether the argument we're handling could be partially undef
-    bool ArgNoUndef = DetermineNoUndef(ParamType, getTypes(), DL, AI);
-    if (CodeGenOpts.EnableNoundefAttrs && ArgNoUndef)
-      Attrs.addAttribute(llvm::Attribute::NoUndef);
+    if (CodeGenOpts.EnableNoundefAttrs) {
+      if (DetermineNoUndef(ParamType, getTypes(), DL, AI))
+        Attrs.addAttribute(llvm::Attribute::NoUndef);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117078/new/

https://reviews.llvm.org/D117078



More information about the cfe-commits mailing list