[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

Son Tuan Vu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 12 11:22:02 PST 2022


tyb0807 marked 2 inline comments as done.
tyb0807 added inline comments.


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:666-675
+  HasHBC |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A ||
+            ArchKind == llvm::AArch64::ArchKind::ARMV9_3A;
+
+  // Check features that are manually disabled by command line options.
+  // This needs to be checked after architecture-related features are handled,
+  // making sure they are properly disabled when required.
+  for (const auto &Feature : Features) {
----------------
nickdesaulniers wrote:
> this whole block is suspect to me. Why is HBC special with regards to all other architectural extensions?
Indeed, HBC does not require the frontend to generate any special intrinsic in the IR, so  the frontend does not need to know about whether HBC is enabled or disabled in the command line. This can thus be completely handled by the target parser.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116939/new/

https://reviews.llvm.org/D116939



More information about the cfe-commits mailing list