[PATCH] D116190: Comment parsing: Don't recognize commands in single-line double quotation

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 12 10:14:03 PST 2022


gribozavr2 added inline comments.


================
Comment at: clang/lib/AST/CommentLexer.cpp:278
+
+again:
+  size_t End =
----------------
I'd suggest refactoring to a `while (true)` if you don't mind.


================
Comment at: clang/lib/AST/CommentLexer.cpp:290
+    if (End != StringRef::npos && *(TokenPtr + End) == '\"')
+      TokenPtr += End + 1;
+    goto again;
----------------
Does Doxygen understand escaped quotes?

```
/// "@hello\"@hello"
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116190/new/

https://reviews.llvm.org/D116190



More information about the cfe-commits mailing list