[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

Wed Jan 12 08:35:25 PST 2022

martong added a comment.

In D105340#3237430 <https://reviews.llvm.org/D105340#3237430>, @ASDenysPetrov wrote:

> In D105340#3232671 <https://reviews.llvm.org/D105340#3232671>, @NoQ wrote:
>
>> This looks great with the option flag. Landing this patch will enable more people to test the new mode and produce feedback on whether the constraint solver keeps working well enough in presence of the new symbols.
>
> Many thanks for your approval, @NoQ! The upset thing is that to get this loaded we also should close this parent revision D103094 <https://reviews.llvm.org/D103094> :-(

Actually, this patch does not depend on `castTo` and thus it is independent from the rest of the patch stack. So we could just land it as it is. (In this patch, you just create the `SymbolCast`s but there is no handling of that in the constraint manager which needs the `castTo`.)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105340/new/

https://reviews.llvm.org/D105340