[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute
Steffen Larsen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 12 08:15:53 PST 2022
steffenlarsen updated this revision to Diff 399334.
steffenlarsen added a comment.
I have made the changes suggested in my previous comment. This makes significantly more changes to the parsing of attribute arguments as the old path was needed for attributes that allow both expressions and types. It also required some new controlling arguments for `ParseExpressionList`.
Because these changes also allow intializer lists in attribute arguments I have added a test case showing that `clang::annotate` parses these but will not accept them.
@erichkeane & @aaron.ballman - Is this in line with what you were thinking?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114439/new/
https://reviews.llvm.org/D114439
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/DiagnosticParseKinds.td
clang/include/clang/Parse/Parser.h
clang/lib/Parse/ParseDecl.cpp
clang/lib/Parse/ParseExpr.cpp
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang/test/Parser/cxx0x-attributes.cpp
clang/test/SemaTemplate/attributes.cpp
clang/utils/TableGen/ClangAttrEmitter.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114439.399334.patch
Type: text/x-patch
Size: 19407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220112/78e205a5/attachment-0001.bin>
More information about the cfe-commits
mailing list