[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.

LG, thanks!



================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:171
+    return true;
+  // FIXME: Remove this std symbol list, as they should be covered by the
+  // above isInSystemHeader check.
----------------
hokein wrote:
> kbobyrev wrote:
> > Any reason not to do this right now? (if we keep the comment, then it's probably better as "Remove this check because it is redundant in the presence of isInSystemHeader")
> We could do it in this patch, I slightly prefer to do it in a followup patch, it'd require some changes in the unittests. (this FIXME was added in the last minute -- at the very beginning I didn't notice that it could be simplified) 
Okay, makes sense, thanks for explaining!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116643/new/

https://reviews.llvm.org/D116643