[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8159
+      std::string BitcodeSuffix;
+      if (TCArgs.hasFlag(options::OPT_fopenmp_target_new_runtime,
+                         options::OPT_fno_openmp_target_new_runtime, true))
----------------
JonChesterfield wrote:
> This looks familiar - is there a function in commonargs that already does this?
It's implemented individually when we select it in the CUDA and AMDGPUOpenMP toolchains, could probably try to unify it into a utility function to save a few lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117048/new/

https://reviews.llvm.org/D117048