[PATCH] D111566: [SYCL] Fix function pointer address space

[Elizabeth Andrews via Phabricator via cfe-commits]

eandrews marked 3 inline comments as done.
eandrews added inline comments.


================
Comment at: clang/include/clang/Basic/TargetInfo.h:763
+  /// Set the address space for functions for the given target.
+  virtual void setProgramAddressSpace() { ProgramAddrSpace = 0; }
+
----------------
I'm not entirely sure about setting the default value to zero here. I set it to 0 here based on default value for ProgramAddrSpace  in DataLayout class (https://llvm.org/doxygen/DataLayout_8cpp_source.html#l00186)

Targets with non-zero value should override this function. I do not know what these targets are (if any). I ran check-llvm and nothing failed. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111566/new/

https://reviews.llvm.org/D111566