[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

Tue Jan 11 11:56:24 PST 2022

arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

LGTM with one comment. This is great, thanks!

================
Comment at: clang/test/Sema/attr-availability-tvos.c:66
+
+#ifdef USE_VERSION_MAP
+// iOS 9.3 corresponds to tvOS 9.2, as indicated in 'SDKSettings.json'.
----------------
Can you add an `#else` test case that shows the old diagnostic saying that it's deprecated in tvOS 9.3?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116822/new/

https://reviews.llvm.org/D116822