[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

Tue Jan 11 07:01:23 PST 2022

pmatos added a comment.

Fixes https://github.com/llvm/llvm-project/issues/30390

================
Comment at: test/SemaCXX/pr31042.cpp:1
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -disable-free %s
+
----------------
efriedma wrote:
> Oh, this testcase doesn't actually crash on trunk without at least -emit-llvm because semantic analysis doesn't actually verify the used bit. :(  Better to include that, I think.
Ah, that's why I had initially `-emit-obj`. That also triggered the problem. I obviously forgot about this and removed the flag without retesting to check if still broke trunk. Apologies for that.

================
Comment at: test/SemaCXX/pr31042.cpp:1
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -disable-free %s
+
----------------
pmatos wrote:
> efriedma wrote:
> > Oh, this testcase doesn't actually crash on trunk without at least -emit-llvm because semantic analysis doesn't actually verify the used bit. :(  Better to include that, I think.
> Ah, that's why I had initially `-emit-obj`. That also triggered the problem. I obviously forgot about this and removed the flag without retesting to check if still broke trunk. Apologies for that.
And we also need to remove `-fsyntax-only`. Submitting new patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D27800/new/

https://reviews.llvm.org/D27800