[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause
Saiyedul Islam via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 11 03:51:13 PST 2022
saiislam updated this revision to Diff 398897.
saiislam added a comment.
1. Used a common diagnostic warning `warn_unknown_declare_variant_isa_trait` for ParseOpenMP and SemaOpenMP for decalre variant and metadirectives.
2. Split lit codegen tests into two files, one requiring amdgpu-registered target and another for host only.
3. Added warning message lit test at an appropriate place.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116549/new/
https://reviews.llvm.org/D116549
Files:
clang/include/clang/Basic/DiagnosticParseKinds.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Parse/ParseOpenMP.cpp
clang/test/OpenMP/metadirective_device_isa_codegen.cpp
clang/test/OpenMP/metadirective_device_isa_codegen_amdgcn.cpp
clang/test/OpenMP/metadirective_messages.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116549.398897.patch
Type: text/x-patch
Size: 6921 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220111/b6090e1f/attachment.bin>
More information about the cfe-commits
mailing list