[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 10 18:35:03 PST 2022


ahatanak updated this revision to Diff 398800.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.

Build the map (`Captures`) after building the vector (`SortedCaptures`).

Also fix a minor bug where a `BlockLayoutChunk` wasn't being removed after being copied when the end of the header wasn't aligned (see `test6` in `CodeGenObjC/blocks.m`), which was needed since `CodeGenObjC/arc-captured-32bit-block-var-layout-2.m` started failing after applying this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116948/new/

https://reviews.llvm.org/D116948

Files:
  clang/lib/CodeGen/CGBlocks.cpp
  clang/lib/CodeGen/CGBlocks.h
  clang/lib/CodeGen/CGObjCMac.cpp
  clang/test/CodeGenObjC/arc-blocks.m
  clang/test/CodeGenObjC/blocks.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116948.398800.patch
Type: text/x-patch
Size: 34131 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220111/78722a3c/attachment-0001.bin>


More information about the cfe-commits mailing list