[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

Mon Jan 10 07:55:22 PST 2022

nikic added a comment.

In D116935#3231615 <https://reviews.llvm.org/D116935#3231615>, @fhahn wrote:

> In D116935#3231477 <https://reviews.llvm.org/D116935#3231477>, @nikic wrote:
>
>> Why do we need / want to use the InstSimplifyFolder in SROA?
>
> I don't have any strong opinions either way. The reason I updated SROA to use it was that there are a few tests that otherwise create some redundant ORs that otherwise are simplified.

I'd go for "do not simplify" as the default assumption, if we don't have any particular motivation to the contrary.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116935/new/

https://reviews.llvm.org/D116935