[PATCH] D115490: [clangd] Include fixer for missing functions in C
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 10 01:43:27 PST 2022
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:14995
+ DeclFilterCCC<FunctionDecl> CCC{};
+ Corrected = CorrectTypo(DeclarationNameInfo(&II, Loc), LookupOrdinaryName,
+ S, nullptr, CCC, CTK_NonError);
----------------
maybe some comments around importance of the sequencing here? it would probably be nice to have that at a higher level documentation too, but unclear where. as in theory it's not just about the typo correction but also emitting diagnostics while doing so.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115490/new/
https://reviews.llvm.org/D115490
More information about the cfe-commits
mailing list